Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Update Library Config #55

Merged
merged 12 commits into from Feb 6, 2019
Merged

misc: Update Library Config #55

merged 12 commits into from Feb 6, 2019

Conversation

sleepdefic1t
Copy link
Contributor

Proposed changes

This PR does the following in the Library Configuration file:

  • lists ArduinoJson as a dependency,
  • adds the Arduino sketch path to config.
  • fixes the platformio_example path.

This allows external package managers to properly list our examples and handle project dependencies.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improve a current implementation without adding a new feature or fixing a bug)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Build (changes that affect the build system)
  • Docs (documentation only changes)
  • Test (adding missing tests or fixing existing tests)
  • Other... Please describe:

adds to and updates library configuration file.

Checklist

  • I have read the CONTRIBUTING documentation
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@sleepdefic1t
Merge pull request #1 from ArkEcosystem/master
7eb3584 
misc: merge from upstream
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
6a878c3
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
6ce1010
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
0c0932b
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
62f8454
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
6e70be7
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
7fad180
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
8f703df
@sleepdefic1t
Merge remote-tracking branch 'upstream/master'
66a527c
@sleepdefic1t
misc: update library config
55d830b 
- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
@sleepdefic1t
Revert "misc: update library config"
a7b16b9 
This reverts commit 55d830b.
@sleepdefic1t
misc: update library config
7d63198 
- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
@ghost
Copy link

ghost commented Feb 5, 2019

@sleepdefic1t Thanks for submitting this pull request, a maintainer will get back to you shortly!

@ghost
Copy link

ghost commented Feb 5, 2019

@faustbrian @air1one - please review this in the next few days. Be sure to explicitly select labels so I know what's going on.

If no reviewer appears after a week, a reminder will be sent out.

@ghost
Copy link

ghost commented Feb 5, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 7d63198373aa41546e1a7718ce2385bb3afb2cc6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

1 similar comment
@ghost
Copy link

ghost commented Feb 5, 2019

@sleepdefic1t The ci/circleci: build-linux-clang-5 job is failing as of 7d63198373aa41546e1a7718ce2385bb3afb2cc6. Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

@sleepdefic1t
Copy link
Contributor Author

Test failure in build-linux-clang-5 is a result of #7

@sleepdefic1t sleepdefic1t mentioned this pull request Feb 5, 2019
Merged
12 tasks
@ghost
Copy link

ghost commented Feb 6, 2019

@sleepdefic1t A contributor has approved this PR. A maintainer will merge this PR shortly. If it shouldn't be merged yet, please leave a comment saying so and we'll wait.

Thank you for your contribution!

@ghost ghost added the Status: Contributor Approved The pull request has been approved by a contributor. label Feb 6, 2019
@faustbrian faustbrian merged commit 16e51a1 into ArkEcosystemArchive:master Feb 6, 2019
@ArkEcosystemArchive ArkEcosystemArchive deleted a comment Feb 6, 2019
@ghost ghost mentioned this pull request Feb 11, 2019
Closed
@sleepdefic1t sleepdefic1t deleted the misc/update-library-config branch February 15, 2019 17:54
ciband pushed a commit to ciband/cpp-crypto that referenced this pull request Feb 18, 2019
@sleepdefic1t @ciband
chore: Update Library Config (ArkEcosystemArchive#55)
c054d69 
* misc: update library config

- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.

* Revert "misc: update library config"

This reverts commit 55d830b.

* misc: update library config

- list ArduinoJson as a dependency.
- add Arduino sketch path to config.
- fix the 'platformio_example' path.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@faustbrian faustbrian faustbrian approved these changes

Assignees
No one assigned
Labels
Status: Contributor Approved The pull request has been approved by a contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sleepdefic1t @faustbrian